8000 [WIP] Rats by benckx · Pull Request #328 · CorsixTH/CorsixTH · GitHub
[go: up one dir, main page]
Skip to content

[WIP] Rats #328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
benckx wants to merge 3 commits into from
Closed

[WIP] Rats #328

benckx wants to merge 3 commits into from

Conversation

@benckx
Copy link
Contributor
@benckx benckx commented Oct 14, 2014

For now it only detects if the hospital is getting dirty and spawns rat holes accordingly. It doesn't create rat holes in the corridors and it creates some of them on the outside of the building, which is probably wrong (this happens when the walls of a room touch the walls of the hospital). I would need to get the coordinates of the hospital walls to fix these, but so far I didn't find how to get that.

Also, if I remember correctly, in TH, rat holes don't appear behind radiators (or drinking machines) and placing such an object in front of a hole was even a way to get rid of it. Can somebody confirm?

When I fire all handyman, it evolves like this (litter rate checked every month):

litter rate: 0.17 %
litter rate: 0.47 %
litter rate: 4.13 %
rat_hole_spawn_rate: 8
rat holes to make: 2
litter rate: 4.78 %
rat_hole_spawn_rate: 9
rat holes to make: 4
litter rate: 5.07 %
rat_hole_spawn_rate: 10
rat holes to make: 2
litter rate: 10.09 %
rat_hole_spawn_rate: 20
rat holes to make: 8

Here is a test saved game (an hospital with few or no handyman):

https://www.dropbox.com/sh/zfb57sosk92nbc9/AACgFreEA-lhsgpvFNToeOpQa/rats?dl=0

@TheCycoONE
Copy link
Member
TheCycoONE commented Oct 14, 2014

Thanks @benckx

We're all busy with 0.40 at the moment, but once those bugs are squashed and it's out the door, it will be nice to take a look at this.

@sadger
Copy link
Contributor
sadger commented Oct 14, 2014

This is very nice, look forward to powing some rats. The dirtiness functions could be very useful for improving the frequency of epidemics depending the the "dirtiness" of the hospital. So keeping it very general is great.

@TheCycoONE TheCycoONE added enhancement issue type P5 Future Priority labels Oct 14, 2014
@MarkL1961
Copy link
Contributor
MarkL1961 commented Oct 19, 2014

Also, if I remember correctly, in TH, rat holes don't appear behind radiators (or drinking machines) and placing such an object in front of a hole was even a way to get rid of it. Can somebody confirm?
You are right on the second part, not the first though. I remember picking up a radiator or drinks machine to delete rat holes to find that there was one behind the radiator or drinks machine as well.

@Grimdoc
Copy link
Contributor
Grimdoc commented Oct 20, 2014

If I remember right you could place drinking machines in front of the rat
holes, and this would either just stop the rat from using that hole, or
removing the hole.

On Sun, Oct 19, 2014 at 9:27 PM, MarkL notifications@github.com wrote:

Also, if I remember correctly, in TH, rat holes don't appear behind
radiators (or drinking machines) and placing such an object in front of a
hole was even a way to get rid of it. Can somebody confirm?
You are right on the second part, not the first though. I remember picking
up a radiator or drinks machine to delete rat holes to find that there was
one behind the radiator or drinks machine as well.

—
Reply to this email directly or view it on GitHub
#328 (comment).

@TheCycoONE TheCycoONE removed the P5 Future Priority label Dec 23, 2014
@TheCycoONE
Copy link
Member
TheCycoONE commented Dec 31, 2014

@benckx 58fe774 makes things pretty messy, a rebase would have been better.

@TheCycoONE TheCycoONE changed the title Rats [WIP] Rats Sep 3, 2015
@TheCycoONE
Copy link
Member
TheCycoONE commented Apr 12, 2016

I don't think there's anything gained by renaming Entity to Creature, lets drop that change. Spawning holes needs to take more into consideration as mentioned above - picking a random wall is probably still the way to go, but if the chosen wall is not suitable for a hole we should either try again or give up (if there are no suitable walls we don't want to be in a non-terminating loop).

I am not sure why rat spawning was set to require a distance > 6, in the original rats would go between much closer holes than that.

As I mentioned above, 58fe774 makes a mess of this PR and needs to be reset out.

@benckx do you plan on taking this up again?

Alberth289346 added a commit to Alberth289346/CorsixTH that referenced this pull request Aug 21, 2016
@Alberth289346
Add homes for rat families in dirty hospitals, based on work by benck…
730c1f9 
…x in CorsixTH#328
Alberth289346 added a commit to Alberth289346/CorsixTH that referenced this pull request Aug 30, 2016
@Alberth289346
Add homes for rat families in dirty hospitals, based on work by benck…
5b2779f 
…x in CorsixTH#328
Alberth289346 added a commit to Alberth289346/CorsixTH that referenced this pull request Sep 11, 2016
@Alberth289346
Add homes for rat families in dirty hospitals, based on work by benck…
81dd26b 
…x in CorsixTH#328
@TheCycoONE
Copy link
Member
TheCycoONE commented Sep 16, 2016

Replaced by #1117

@TheCycoONE TheCycoONE closed this Sep 16, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

enhancement issue type

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@benckx @TheCycoONE @sadger @MarkL1961 @Grimdoc
0