8000 Fix API base setting spec by laurynas-convertapi · Pull Request #33 · ConvertAPI/convertapi-library-php · GitHub
[go: up one dir, main page]
Skip to content

Fix API base setting spec #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
laurynas-convertapi merged 1 commit into from
Jun 26, 2022
Merged

Fix API base setting spec #33

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion tests/ConvertApi/ConvertApiTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ protected function setUp()
{
// Save original values so that we can restore them after running tests
$this->origApiSecret = ConvertApi::getApiSecret();
$this->origApiBase = ConvertApi::getApiBase();
$this->origUploadTimeout = ConvertApi::$uploadTimeout;

ConvertApi::setApiSecret(getenv('CONVERT_API_SECRET'));
Expand All @@ -21,6 +22,7 @@ protected function tearDown()
{
// Restore original values
ConvertApi::setApiSecret($this->origApiSecret);
ConvertApi::setApiBase($this->origApiBase);
ConvertApi::$uploadTimeout = $this->origUploadTimeout;
}

Expand All @@ -29,7 +31,7 @@ public function testConfigurationAccessors()
ConvertApi::setApiSecret('test-secret');
$this->assertEquals('test-secret', ConvertApi::getApiSecret());

ConvertApi::setApiSecret('https://foo.bar');
ConvertApi::setApiBase('https://foo.bar');
$this->assertEquals('https://foo.bar', ConvertApi::getApiBase());
}

Expand Down
0