10000 Be more lenient with version checks when updating the minor version of the game by DerEchtePilz · Pull Request #594 · CommandAPI/CommandAPI · GitHub
[go: up one dir, main page]
Skip to content

Be more lenient with version checks when updating the minor version of the game #594

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Aug 14, 2024
Merged

Be more lenient with version checks when updating the minor version of the game #594

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
8573cf2
Be more lenient when updating the minor version of the game
DerEchtePilz Aug 12, 2024
6b6eff2
Add an option to the plugin config
DerEchtePilz Aug 12, 2024
3573fec
Update documentation and changelog
DerEchtePilz Aug 12, 2024
c8c286a
Address code reviews
DerEchtePilz Aug 13, 2024
20c5e89
Minor JavaDocs adjustments
DerEchtePilz Aug 13, 2024
ccb11f6
Tweak Javadocs
DerEchtePilz Aug 13, 2024
e0e73c5
Add a LoadContext to only display a warning when applicable
DerEchtePilz Aug 13, 2024
9fd01bf
Address more code review
DerEchtePilz Aug 14, 2024
8d5b0a0
Fix config option name in setup_shading
DerEchtePilz Aug 14, 2024
dd1bde3
Even more code review
DerEchtePilz Aug 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Tweak Javadocs 
Co-authored-by: willkroboth <46540330+willkroboth@users.noreply.github.com>
  • Loading branch information
@DerEchtePilz @willkroboth
DerEchtePilz and willkroboth authored Aug 13, 2024
commit ccb11f69032eff24484f7f1b9a2fa4431f826826
3 changes: 1 addition & 2 deletions commandapi-core/src/main/java/dev/jorel/commandapi/CommandAPIConfig.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,8 +96,7 @@ public Impl useLatestNMSVersion(boolean value) {
* when updating to a minor release of Minecraft. As an example, this setting can allow
* updating to 1.21.2 from 1.21.1 but doesn't allow updating to 1.22 from 1.21.2.
* Unlike {@link #useLatestNMSVersion(boolean)}, this setting does
* not blindly load the latest NMS version and as a result breaks cross version compatibility
* but will actually prefer loading the correct NMS implementation.
* not blindly load the latest NMS version, but will prefer loading the correct NMS implementation when available.
*
* @param value whether the CommandAPI should assume that minor Minecraft releases do not cause incompatibilities
* @return this CommandAPIConfig
Expand Down
Loading
0