Adding some more tests

CommandAPI · JorelAli · Mar 4, 2023 · Jan 29, 2023 · Jan 29, 2023 · Jan 29, 2023
commit 4f0dd4a0ff3f375bae959cd215d5cefcccf27d71
diff --git a/...kkit/commandapi-bukkit-core/src/main/java/dev/jorel/commandapi/arguments/MapArgument.java b/...kkit/commandapi-bukkit-core/src/main/java/dev/jorel/commandapi/arguments/MapArgument.java
@@ -351,7 +351,7 @@ private boolean validateKey(StringBuilder visitedCharacters, Pattern keyPattern,
 		if (!keyPattern.matcher(keyValueBufferString).matches()) {
 			throw throwInvalidKeyCharacter(visitedCharacters);
 		}
-		return !keyList.contains(keyValueBufferString);
+		return !keyList.contains(keyValueBufferString) && !keyListEmpty;
 	}
 
 	private void validateValueStart(char currentChar, StringBuilder visitedCharacters) throws CommandSyntaxException {

diff --git a/...bukkit-test-tests/src/test/java/dev/jorel/commandapi/test/arguments/ArgumentMapTests.java b/...bukkit-test-tests/src/test/java/dev/jorel/commandapi/test/arguments/ArgumentMapTests.java
@@ -42,6 +42,8 @@ public void tearDown() {
 	 * Tests *
 	 *********/
 
+	// TODO: Suggestion test!!!
+
 	@Test
 	public void executionTestWithMapArgument() {
 		Mut<LinkedHashMap<String, String>> results = Mut.of();
@@ -77,6 +79,21 @@ public void executionTestWithMapArgument() {
 		testMap.put("test", "Test value");
 		assertEquals(testMap, results.get());
 
+		// /test map:"cool map" map:"bar"
+		assertCommandFailsWith(player, "test map:\"cool map\" map:\"bar\"", "Could not parse command: Duplicate keys are not allowed at position 19: ...l map\" map<--[HERE]");
+
+		// /test map:
+		assertCommandFailsWith(player, "test map:", "Could not parse command: Quotation mark required after writing the delimiter at position 4: map:<--[HERE]");
+
+		// /test map
+		assertCommandFailsWith(player, "test map", "Could not parse command: Delimiter required after writing a key at position 3: map<--[HERE]");
+
+		// /test map:"
+		assertCommandFailsWith(player, "test map:\"", "Could not parse command: Value required after opening quotation mark at position 5: map:\"<--[HERE]");
+
+		// /test map:"this" otherMap:"this"
+		assertCommandFailsWith(player, "test map:\"this\" otherMap:\"this\"", "Could not parse command: Duplicate values are not allowed here at position 26: ...rMap:\"this<--[HERE]");
+
 		assertNoMoreResults(results);
 	}