8000 fix(exporter): add missing tags of percussion in gp exporter by L-Sun · Pull Request #2468 · CoderLine/alphaTab · GitHub
[go: up one dir, main page]
Skip to content

fix(exporter): add missing tags of percussion in gp exporter #2468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
L-Sun wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

fix(exporter): add missing tags of percussion in gp exporter #2468

L-Sun wants to merge 3 commits into from

Conversation

@L-Sun
Copy link
Contributor
@L-Sun L-Sun commented Dec 28, 2025

Issues

Fixes #2467

Proposed changes

This PR fixes missing percussion articulation data in the GP exporter that prevented RSE (Realistic Sound Engine) from working properly in Guitar Pro 8 for exported drum tracks.

Changes made:

  • Added missing OutputRSESound tag to percussion articulations, which is essential for RSE sound mapping in Guitar Pro
  • Added InputMidiNumbers tag with proper values (was previously empty)
  • Added SoundbankName tag to percussion elements
  • Improved percussion element grouping logic to use elementName (falling back to elementType when not available)
  • Used articulationName when available instead of generating generic names
  • Refactored PercussionMapper to include the new articulation properties needed for proper GP export
  • Added serialization support for the new InstrumentArticulation fields

These changes ensure that exported GP files contain all the necessary metadata for Guitar Pro 8's RSE to properly map and play drum sounds.

Checklist

  • I consent that this change becomes part of alphaTab under it's current or any future open source license
  • Changes are implemented
  • New tests were added

Further details

  • This is a breaking change
  • This change will require update of the documentation/website

@L-Sun L-Sun changed the title Fix percussion rse fix(exporter): add missing tags of percussion in gp exporter Dec 28, 2025
@L-Sun L-Sun force-pushed the fix-percussion-rse branch from e9e68eb to 1adfd3f Compare December 28, 2025 07:22
@L-Sun L-Sun marked this pull request as draft December 28, 2025 07:34
@L-Sun L-Sun force-pushed the fix-percussion-rse branch from 53b3e74 to 8b564e4 Compare December 28, 2025 08:10
@L-Sun L-Sun marked this pull request as ready for review December 28, 2025 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Exported GP files have no sound when switching drum tracks to RSE in Guitar Pro 8

1 participant

@L-Sun
0