8000 fix: External Cursor API related problems by Danielku15 · Pull Request #2117 · CoderLine/alphaTab · GitHub
[go: up one dir, main page]
Skip to content

fix: External Cursor API related problems #2117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Danielku15 merged 3 commits into from
May 22, 2025
Merged

fix: External Cursor API related problems #2117

Danielku15 merged 3 commits into from
May 22, 2025

Conversation

@Danielku15
Copy link
Member
@Danielku15 Danielku15 commented May 22, 2025

Issues

Relates to #1961

Proposed changes

Fixes some more findings around the external cursor api changes:

  • The beat cursor was animating too far in some cases. We now respect the animation hint whether animation should only go to the end of the bar (e.g. on repeats or song ends).
  • Sync points were generated double after the refactoring
  • The double update of sync points in the midi sequencer was wrong as it mixed the backing track and alphatab time axis.

Checklist

  • I consent that this change becomes part of alphaTab under it's current or any future open source license
  • Changes are implemented
  • New tests were added

Further details

  • This is a breaking change
  • This change will require update of the documentation/website

@Danielku15 Danielku15 self-assigned this May 22, 2025
@Danielku15 Danielku15 merged commit 0b4cd7b into develop May 22, 2025
5 checks passed
@Danielku15 Danielku15 deleted the feature/syncpoint-api-finalization2 branch May 22, 2025 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@Danielku15 Danielku15

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Danielku15
0