8000 feat(musicxml): Improve beam and bar handling by Danielku15 · Pull Request #2035 · CoderLine/alphaTab · GitHub
[go: up one dir, main page]
Skip to content

feat(musicxml): Improve beam and bar handling #2035

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Danielku15 merged 2 commits into from
Apr 17, 2025
Merged

feat(musicxml): Improve beam and bar handling #2035

Danielku15 merged 2 commits into from
Apr 17, 2025

Conversation

@Danielku15
Copy link
Member
@Danielku15 Danielku15 commented Apr 17, 2025

Issues

relates to #1887

Proposed changes

Improves two aspects of the musicxml importer:

  1. we set the beaming mode to auto if there are no beams specified within the file. (for now we simply use the first encounter to determine if beams are explicit)
  2. we now simply use the index of the measure tags as bar indexes.

Checklist

  • I consent that this change becomes part of alphaTab under it's current or any future open source license
  • Changes are implemented
  • New tests were added

Further details

  • This is a breaking change
  • This change will require update of the documentation/website

@Danielku15 Danielku15 self-assigned this Apr 17, 2025
@Danielku15 Danielku15 force-pushed the feature/simply-musicxml branch from fc48022 to 3148b0c Compare April 17, 2025 13:15
@Danielku15 Danielku15 merged commit 98bb6b6 into develop Apr 17, 2025
5 checks passed
@Danielku15 Danielku15 deleted the feature/simply-musicxml branch April 17, 2025 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@Danielku15 Danielku15

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Danielku15
0