10000 Remove param flags from authentication methods by TavoNiievez · Pull Request #70 · Codeception/module-symfony · GitHub
[go: up one dir, main page]
Skip to content

Remove param flags from authentication methods #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 11, 2020
Merged

Remove param flags from authentication methods #70

merged 3 commits into from
Dec 11, 2020

Conversation

TavoNiievez
Copy link
Member

With this PR the parameter flags of the authentication methods are removed ($remembered in this case), in addition, the following functions are added:

public function seeRememberedAuthentication()
public function dontSeeRememberedAuthentication()

In order to supplement the previous functionality.

It's only a BC if you used seeAuthentication or dontSeeAuthentication with true as an argument.

@TavoNiievez TavoNiievez added this to the 1.5.0 milestone Dec 9, 2020
@TavoNiievez TavoNiievez mentioned this pull request Dec 9, 2020
Closed
11 tasks
@TavoNiievez TavoNiievez merged commit a219184 into Codeception:master Dec 11, 2020
@TavoNiievez TavoNiievez deleted the seeAuth branch December 11, 2020 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Naktibalda Naktibalda Awaiting requested review from Naktibalda

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.5.0
Development

Successfully merging this pull request may close these issues.
1 participant
@TavoNiievez
0