8000 Code standards updated to PHP 7.1 by TavoNiievez · Pull Request #12 · Codeception/module-phpbrowser · GitHub
[go: up one dir, main page]
Skip to content

Code standards updated to PHP 7.1 #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 27, 2021
Merged

Code standards updated to PHP 7.1 #12

merged 2 commits into from
May 27, 2021

Conversation

TavoNiievez
Copy link
Member
  • The minimum version of PHP is now 7.1
  • Added strict types
  • Added return types
  • Added typehints
  • Removed unnecessary qualifiers

@TavoNiievez TavoNiievez marked this pull request as ready for review May 13, 2021 02:48
@TavoNiievez TavoNiievez requested a review from Naktibalda May 13, 2021 02:48
Naktibalda
Naktibalda reviewed May 18, 2021
View reviewed changes
@TavoNiievez TavoNiievez merged commit e66eec9 into Codeception:master May 27, 2021
@TavoNiievez TavoNiievez deleted the return-types branch May 27, 2021 19:54
TavoNiievez added a commit to TavoNiievez/module-phpbrowser that referenced this pull request May 27, 2021
@TavoNiievez
Code standards updated to PHP 7.1 (Codeception#12)
04a18eb
Naktibalda added a commit that referenced this pull request Jun 6, 2021
@Naktibalda
Cast uri to string
350f719 
This casting was removed by modernization PR #12
It is necessary to fix Codeception 5 build.
@Naktibalda Naktibalda mentioned this pull request Jun 6, 2021
Merged
TavoNiievez pushed a commit that referenced this pull request Jun 6, 2021
@Naktibalda
Cast uri to string (#14)
abe753b 
This casting was removed by modernization PR #12
It is necessary to fix Codeception 5 build.
@TavoNiievez TavoNiievez added this to the 2.0.0 milestone Dec 4, 2021
@renovate renovate bot mentioned this pull request Jan 23, 2022
Closed
1 task
@renovate renovate bot mentioned this pull request Mar 20, 2022
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Naktibalda Naktibalda Naktibalda approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@TavoNiievez @Naktibalda
0