[bugfix] #49 Fix last insert id return type in case of dblib (3.x) #56
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s with false in case of dblib
|
I wanted to check in on the status of my pull request. I would greatly appreciate any feedback you might have on the fix I've proposed. Thanks for your time and consideration! |
|
@Naktibalda @TavoNiievez are we ok to merge this? |
|
@szhajdu sorry, looks like no one currently can merge PR, but I can make you a maintainer instead |
|
@DavertMik OK, I'm in. |
|
@szhajdu please check, I sent you invite @Naktibalda FYI ^ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up on #51
See #55 for details