8000 Add no_cleanup_failed option for not cleaning up failed tests by Archanium · Pull Request #30 · Codeception/module-db · GitHub
[go: up one dir, main page]
Skip to content

Add no_cleanup_failed option for not cleaning up failed tests #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 5, 2022
Merged

Add no_cleanup_failed option for not cleaning up failed tests #30

merged 3 commits into from
Mar 5, 2022

Conversation

Archanium
Copy link
Contributor
@Archanium Archanium commented Jan 6, 2022 •
edited
Loading

I thought I'd add an option for not having it cleanup the database in case the test failed.

@Archanium Archanium marked this pull request as ready for review January 6, 2022 12:36
@Archanium
Copy link
Contributor Author

It will most likely need a cleanup once the debugging is done. 😄

Naktibalda
Naktibalda reviewed Jan 6, 2022
View reviewed changes
src/Codeception/Module/Db.php Outdated
@@ -260,6 +260,7 @@ class Db extends Module implements DbInterface
'waitlock' => 0,
'dump' => null,
'populator' => null,
'no_cleanup_failed' => false,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that skip_cleanup_if_failed would be a better name for this setting.

@Naktibalda Naktibalda requested a review from TavoNiievez January 6, 2022 16:34
TavoNiievez
TavoNiievez reviewed Jan 6, 2022
View reviewed changes
Copy link
Member
@TavoNiievez TavoNiievez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This new configuration option must be documented in more places than in the documentation for the haveInDatabase method, for example on line 48-65 of this file, and in some of the yml examples below.

@Naktibalda Naktibalda merged commit 8f97f19 into Codeception:master Mar 5, 2022
Naktibalda pushed a commit that referenced this pull request Mar 5, 2022
@Archanium @Naktibalda
Add skip_cleanup_if_failed option for not cleaning up failed tests (#30)
cbc1954 
* Add no_cleanup_failed option for not cleaning up failed tests

* Update to handle all databases

* Change name from 'no_cleanup_failed' to 'skip_cleanup_if_failed'
Naktibalda pushed a commit that referenced this pull request Mar 5, 2022
@Archanium @Naktibalda
Add skip_cleanup_if_failed option for not cleaning up failed tests (#30)
04c3e66 
* Add no_cleanup_failed option for not cleaning up failed tests

* Update to handle all databases

* Change name from 'no_cleanup_failed' to 'skip_cleanup_if_failed'
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TavoNiievez TavoNiievez TavoNiievez approved these changes

@Naktibalda Naktibalda Awaiting requested review from Naktibalda

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Archanium @Naktibalda @TavoNiievez
0