10000 Fix PHP 8.4 deprecation. by kagg-design · Pull Request #6811 · Codeception/Codeception · GitHub
[go: up one dir, main page]
Skip to content

Fix PHP 8.4 deprecation. #6811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 8, 2024
Merged

Fix PHP 8.4 deprecation. #6811

merged 1 commit into from
Dec 8, 2024

Conversation

kagg-design
Copy link
Contributor

No description provided.

@W0rma
Copy link
Contributor
W0rma commented Dec 4, 2024

This PR should fix the last remaining PHP 8.4 deprecation warning.

@SamMousa @Naktibalda It would be great to have a new release after this MR is merged.

@ThomasLandauer
Copy link
Member

Tadaa, the PR with the most approvals ever ;-)

@TavoNiievez TavoNiievez merged commit 092fa32 into Codeception:main Dec 8, 2024
10 checks passed
@W0rma W0rma mentioned this pull request Dec 18, 2024
Closed
@ThomasLandauer
Copy link
Member

Could you please tag a new version, to actually get rid of those warnings?

@TavoNiievez
Copy link
Member

Hi @ThomasLandauer I'm not familiar with the process in the main repo.
I remember once I made one but I didn't move I don't know which constant or execute I don't know which command.
I can only merge.

@ThomasLandauer
Copy link
Member

Ping @Naktibalda :-)

@laoneo
Copy link
Contributor
laoneo commented Jan 22, 2025

Probably not more like what he did in 3b2d7d1. And then a tag so the release will appear on packagist. The releases itself do not look like that were some special assets built.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SamMousa SamMousa SamMousa approved these changes

@ThomasLandauer ThomasLandauer ThomasLandauer approved these changes

@W0rma W0rma W0rma approved these changes

@TavoNiievez TavoNiievez TavoNiievez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@kagg-design @W0rma @ThomasLandauer @TavoNiievez @laoneo @SamMousa
0