8000 feat: Support binary data by pongee · Pull Request #6708 · Codeception/Codeception · GitHub
[go: up one dir, main page]
Skip to content

feat: Support binary data #6708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 28, 2023
Merged

feat: Support binary data #6708

merged 1 commit into from
Nov 28, 2023

Conversation

pongee
Copy link
Contributor
@pongee pongee commented Nov 8, 2023

Hi,

Unfortunately if a suite got binary data, and this suite failed, then we can't see the problem. We see json_error problem:

In Descriptor.php line 52:                                                            
Malformed UTF-8 characters, possibly incorrectly encoded

Expected (example):

There was 1 failure:
1) TestCest: My suite | "��K�r��B�\"
 Test  tests/TestCest.php:mySuite
 Step  Assert equals false,true
 Fail  Failed asserting that true matches expected false.

Scenario Steps:
 1. $I->assertEquals(false,true)

Was same problem in codeception-db as well: Codeception/module-db#48

@Naktibalda Naktibalda merged commit afb948b into Codeception:5.0 Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pongee @Naktibalda
0