8000 Make symfony bootstrap.php.cache optional for php version > 7 by patrickjahns · Pull Request #4081 · Codeception/Codeception · GitHub
[go: up one dir, main page]

Skip to content

Make symfony bootstrap.php.cache optional for php version > 7 #4081

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 14, 2017
Merged

Make symfony bootstrap.php.cache optional for php version > 7 #4081

merged 1 commit into from
Apr 14, 2017

Conversation

patrickjahns
Copy link
Contributor

As per #3829 - this PR allows for not requiring bootstrap.php.cache any longer for php versions > 7 - but will still use it if is available

*
* @throws ModuleRequireException
*/
private function initialize_symfony_cache() {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Method name Symfony::initialize_symfony_cache is not in camel caps format
  • Opening brace should be on a new line

@Naktibalda
Copy link
Member

Does it actually depend on a version of PHP or on a version of Symfony?

@patrickjahns
Copy link
Contributor Author

According to #3829 and most of the issues on the symfony tracker, class cache won't be needed in php7. And is also being deprecated
see: symfony/symfony#20668

As mentioned in #3829 I left it there to be optionally included - but we can also discuss to completely deprecate it in the future?

@Naktibalda Naktibalda requested a review from raistlin April 10, 2017 19:26
Copy link
Member
@Naktibalda Naktibalda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is fine with me, but I don't use this module.

@DavertMik
Copy link
Member

Ok, makes sense. Thanks for the Pull Request

@DavertMik DavertMik merged commit 85c0ea8 into Codeception:2.2 Apr 14, 2017
chris1312 pushed a commit to chris1312/Codeception that referenced this pull request Jun 16, 2017
@patrickjahns patrickjahns deleted the feature/optional-symfony-bootstrap-cache branch January 19, 2018 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
0