Make symfony bootstrap.php.cache optional for php version > 7 #4081
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nitpick-CI
reviewed
Mar 27, 2017
src/Codeception/Module/Symfony.php
Outdated
| * | ||
| * @throws ModuleRequireException | ||
| */ | ||
| private function initialize_symfony_cache() { |
There was a problem hiding this comment.
- Method name
Symfony::initialize_symfony_cacheis not in camel caps format - Opening brace should be on a new line
|
Does it actually depend on a version of PHP or on a version of Symfony? |
|
According to #3829 and most of the issues on the symfony tracker, class cache won't be needed in php7. And is also being deprecated As mentioned in #3829 I left it there to be optionally included - but we can also discuss to completely deprecate it in the future? |
Naktibalda
approved these changes
Apr 10, 2017
|
Ok, makes sense. Thanks for the Pull Request |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per #3829 - this PR allows for not requiring bootstrap.php.cache any longer for php versions > 7 - but will still use it if is available