Update regex for better data cleaning#1
Open
acalvino4 wants to merge 2 commits intoCodecademy:masterfrom
Open
Conversation
|
GuessNumber.zip |
|
|
Author
|
Any reason not to merge this? Not that it really matters to me...was just looking through my old pull requests on github and noticed this was still open. merging my fix might save some users of the tutorial a little frustration down the road. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The regex in cc_markov.py was set to clean data from most punctuation, but not parenthesis, forward slash, backslash, or double quote characters. I updated the regex to clean the data more thoroughly from these characters.