fix: address security vulnerabilities in viz server and bundle import#726
Open
007vasy wants to merge 1 commit intoCodeGraphContext:mainfrom
Open
fix: address security vulnerabilities in viz server and bundle import#726007vasy wants to merge 1 commit intoCodeGraphContext:mainfrom
007vasy wants to merge 1 commit intoCodeGraphContext:mainfrom
Conversation
- Restrict /api/file endpoint to only serve files within allowed project directories, preventing arbitrary file read - Tighten CORS policy from wildcard (*) to localhost-only origins, preventing cross-origin exfiltration attacks - Validate Cypher identifiers (node labels and relationship types) in bundle import to prevent Cypher injection via malicious .cgc files - Add zip-slip protection to bundle extraction by validating member paths before extractall() Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
@007vasy is attempting to deploy a commit to the shashankss1205's projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/api/file: The endpoint accepted any filesystem path without restriction. Now validates that resolved paths are within allowed project directories, returning 403 otherwise.allow_origins=["*"]to localhost-only origins, preventing cross-origin exfiltration attacks from malicious websites..cgcbundle JSONL files were interpolated directly into Cypher queries via f-strings. Added identifier validation (^[A-Za-z_][A-Za-z0-9_]*$) before interpolation.extractall()was called without validating member paths. Added path traversal check to ensure no ZIP entry escapes the extraction directory.Test plan
/api/filereturns 403 for paths outside the project directory (e.g.,/etc/passwd)/api/filestill serves files within the visualized project directory.cgcbundle still works}) is rejected with a warningValueError🤖 Generated with Claude Code