10000 Fix Split View Can't Collapse by thecoolwinter · Pull Request #2071 · CodeEditApp/CodeEdit · GitHub
[go: up one dir, main page]
Skip to content

Fix Split View Can't Collapse #2071

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 26, 2025
Merged

Fix Split View Can't Collapse #2071

merged 1 commit into from
Jun 26, 2025

Conversation

thecoolwinter
Copy link
Collaborator

Description

Fixes an erroneous overridden method causing split views to not be collapsable.

Related Issues

Checklist

  • I read and understood the contributing guide as well as the code of conduct
  • The issues this PR addresses are related to each other
  • My changes generate no new warnings
  • My code builds and runs on my machine
  • My changes are all related to the related issue above
  • I documented my code

Screenshots

Screen.Recording.2025-06-23.at.11.21.38.AM.mov

@thecoolwinter thecoolwinter added the bug Something isn't working label Jun 23, 2025
@austincondiff
Copy link
Collaborator
austincondiff commented Jun 23, 2025 •
edited
Loading

Nice catch! How do editor splits work with this? We do not want editors to collapse on drag.

@thecoolwinter
Copy link
Collaborator Author

Nice catch! How do editor splits work with this? We do not want editors to collapse on drag.

Those are handled differently and retain the correct behavior with this change.

@thecoolwinter thecoolwinter merged commit 422b7bf into CodeEditApp:main Jun 26, 2025
2 checks passed
@thecoolwinter thecoolwinter deleted the fix/splitviewcontroller-collapse branch June 26, 2025 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@austincondiff austincondiff austincondiff approved these changes

@0xWDG 0xWDG 0xWDG approved these changes

@tom-ludwig tom-ludwig tom-ludwig approved these changes

@matthijseikelenboom matthijseikelenboom Awaiting requested review from matthijseikelenboom

@FastestMolasses FastestMolasses Awaiting requested review from FastestMolasses

@georgetchelidze georgetchelidze Awaiting requested review from georgetchelidze

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🐞 Utility Area Cannot Collapse with Drag
4 participants
@thecoolwinter @austincondiff @0xWDG @tom-ludwig
0