Add code paths to compile and execute UTF-8 buffers directly #694
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change avoids allocating large UTF-16 strings when the source material is in UTF-8, which is approximately 100% of the Web. The specific use case for myself is obtaining a native pointer to a buffer from the Unity game engine and passing it straight through to ClearScript's native side. When loading code files using managed code, a single buffer the size of the largest code file can be reused.
I'll add tests and more overloads after you indicate that you would accept this at all.
The T4 is generating lots of additional empty lines. Afacit, that is correct given the template code, but then why weren't they there in the first place.