8000 Updates to Rulesets, Tests, & Functions by dtolb · Pull Request #25 · CiscoDevNet/api-insights-openapi-rulesets · GitHub
[go: up one dir, main page]

Skip to content

Conversation

dtolb
Copy link
Contributor
@dtolb dtolb commented Aug 9, 2024

Updates the module.exports to export default and the require to imports

Extracts commonAbbreviates to it's own file instead of object in js file

Adds new documentation rules & supporting functions

@dtolb dtolb changed the title Update to module syntax Updates to Rulesets, Tests, & Functions Aug 12, 2024
@dtolb dtolb marked this pull request as draft August 12, 2024 20:24
@npateriya npateriya requested a review from coliu19 August 12, 2024 22:57
Copy link
Contributor
@coliu19 coliu19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lg2m except some minor issues

beforeAll(() => {
spectral = prepLinter(ruleset, ruleName);
});
test('should throw an error if ...', async () => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

... need to be replaced with real content.

z_tester.yaml Outdated
@@ -0,0 +1,449 @@
openapi: 3.0.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this file seems useless?

@dtolb dtolb marked this pull request as ready for review August 26, 2024 21:01
@coliu19 coliu19 merged commit 66b940c into CiscoDevNet:main Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

0