fix: WHISPER_CPP_MAIN_PATH constant in win32 platform & define execPath when using electron #178
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 Needed this for electron Also needed a fix for models directory, which you can see at my fork: |
|
Thanks @moraxh! the Electron shelljs configuration is great and needed. however, the Windows path change conflicts with our recent CMake improvements. could you please keep the shell.config.execPath changes and revert the WHISPER_CPP_MAIN_PATH change |
|
Thanks @nickdebaise that path resolution fix look useful for Electron/webpack scenarios. I'll create a separate PR to address this properly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces several modifications to the
nodejs-whisperproject to configure theshelljslibrary to utilize the Node.js executable path. The key changes include updates across multiple files to setshell.config.execPathto the Node.js executable path.Configuration of
shelljs:src/autoDownloadModel.ts: Added configuration to setshell.config.execPathto the Node.js executable path.src/downloadModel.ts: Added configuration to setshell.config.execPathto the Node.js executable path.src/utils.ts: Added configuration to setshell.config.execPathto the Node.js executable path.src/whisper.ts:Added configuration to setshell.config.execPathto the Node.js executable path.Update to the
WHISPER_CPP_MAIN_PATHconstant:src/constants.ts: Updated theWHISPER_CPP_MAIN_PATHfor the Windows platform by removing theReleasedirectory from the path.Additional Reference:
For more information on
shelljscompatibility with Electron and configuring theexecPath, please refer to the ShellJS Electron compatibility wiki