Add pair_conversion registration helper with unit test #482
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9c279c1 to
a5a756a
Compare
|
Why wasn't this merged? |
|
Whoa, this looks old. |
|
@BerndAmend Ah, looks like the format change caused a conflict here. Had merged this one by accident first... |
|
Thanks! |
|
@totalgee will you update or create a new PR? |
|
Yes, I will try to make a new PR in the coming days... |
|
I messed up the pair here. Thank you both for following up and pushing all these forwards! 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue this pull request references: Discussion in forum thread
Changes proposed in this pull request
pair_conversion()registration helper, analogous to the existingvector_conversion()andmap_conversion()helpers.