Add hardware acceleration #525
Open
+134
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using Lsio base Suport for AMD, Intel, Nvidia and others
Parse FFMPEG_ARGS and FFMPEG_OUTPUT_ARGS into arrays Detect 'qsv' and 'cuda' flags and map codecs to Hardware encoders (h264_qsv/hevc_qsv and h264_nvenc/hevc_nvenc) Make codec_short mutable to allow reassignment Log constructed ffmpeg command for visibility Enables runtime custom ffmpeg args and hw encoder selection Improves deployment flexibility and performance tuning
There was a problem hiding this comment.
3 issues found across 2 files
Prompt for AI agents (all issues)
Check if these issues are valid — if so, understand the root cause of each and fix them.
<file name="Dockerfile">
<violation number="1" location="Dockerfile:52">
P2: Hard-coded x86_64 multiarch paths in buildstage and LIBVA_DRIVERS_PATH break arm64 builds and VAAPI driver discovery when building for aarch64.</violation>
</file>
<file name="src/converters/ffmpeg.ts">
<violation number="1" location="src/converters/ffmpeg.ts:751">
P2: CUDA hardware acceleration cases incorrectly select Intel QSV encoders instead of NVIDIA NVENC encoders.</violation>
<violation number="2" location="src/converters/ffmpeg.ts:761">
P2: Incorrect removal of hardware-accel args: slice keeps only the element before -hwaccel and drops all other args instead of removing -hwaccel and its value.</violation>
</file>
Since this is your first cubic review, here's how it works:
- cubic automatically reviews your code and comments on bugs and improvements
- Teach cubic by replying to its comments. cubic learns from your replies and gets better over time
- Ask questions if you need clarification on any suggestion
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
Co-authored-by: cubic-dev-ai[bot] <191113872+cubic-dev-ai[bot]@users.noreply.github.com>
Co-authored-by: cubic-dev-ai[bot] <191113872+cubic-dev-ai[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make this pr obsolete: #480
fix #523
add drivers, need configuration to fix #518
Testing:
ghcr.io/webysther/convertx:hwadocker compose for intel:
Same as documentation in lsio for intel, amd and others. We need volunteer to test with gpu.