Fix double lines in CRLF EOL endings#45
Open
sewbacca wants to merge 2 commits intoBigBahss:masterfrom
Open
Conversation
|
I have another change ready to go:
But it seems this repo is not maintained anymore, |
Author
|
Sure, I'd be happy to move it over. Just ping me the deeds, if you decided to fork the repository. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed a strange bug when using CRLF line endings.
Whenever i wanted to add a definition, somehow an excess of newlines would appear, e.g.:
Which seemed strange, at first and after a little digging, I found the issue:
Whenever you add tabspaces to a block, you appear to use
insertText.replace(/^/gm, util.indentation())to prepend any indentation. Unfortunatly it does work only with LF line endings. When using CRLF line endings, it assumes the\rand\nare both line seperators (instead of completly\r\n), which led to inserting tabspaces between and after them, resulting in\r\t\n\t. Then, vscode would translate these into\r\n\t\r\n\t(or at least in an equivalent visual representation).To fix the issue, I have created a function in
utilities, calledinsertBeforeEachLine, which solves the issue and I have replaced each occurence$1.replace(/^/gm, $2)withutil.insertBeforeEachLine($1, $2).