This repository was archived by the owner on Apr 29, 2025. It is now read-only.
Uses the test container if exists #139
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2eef810 to
d9d389c
Compare
|
👍 |
|
@sroze could you please create a release? |
|
It's introducing a same BC break in this extension - symfony/symfony#27494. |
|
What do you mean?
…On Wed, Jun 6, 2018 at 7:55 AM Kamil Kokot ***@***.***> wrote:
It's introducing a same BC break in this extension - symfony/symfony#27494
<symfony/symfony#27494>.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#139 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAxHEVLHubp1j4xCLR4zgMSPb74Ot_ODks5t53z-gaJpZM4TLozw>
.
|
|
for anyone using a custom container based class for their main container, the container injected here is not the custom one anymore (as it is the test container). So we would have to expose this in a different way |
|
actually, as it is used only in the argument resolver, I don't think it suffers from the BC break |
|
Yeah, if it's used as only as an argument resolver, then it wouldn't be a BC break indeed. |
|
so a release could be done, as it is no BC break? |
|
ping @sroze |
|
Released in 2.1.5. |
|
Thank you 🎉 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Symfony 4.1, we (actually, @nicolas-grekas) added the ability to get private services from the container (symfony/symfony#26499). We need to leverage this within Behat's extension.