Enable React 19 usage (#7710) #7735
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enable React 19 applications to use this package, it was released on a while back now: https://react.dev/blog/2024/12/05/react-19. This PR enables applications using react 19 to consume the package, while continuing to allow react 18 applications to continue using this package unhindered. --------- Co-authored-by: Herman Jensen <herman.jensen@intility.no>
|
There's one fix in the Electron node sample needed, as the JSX namespace was moved to React.JSX in react 19 rm-eth-a-n#3 |
Let's wait for the results of CI and any needed changes can be PR'd into this branch |
sameerag
previously approved these changes
May 6, 2025
|
Looks like the failures are all related to our internal repo which is not open source. I'll make the needed changes later today or tomorrow and get this merged in. Thanks again! @h3rmanj If you want to PR your change into this branch feel free. I can otherwise take care of it later given it's just a one liner. |
This was referenced May 6, 2025
This was
linked to
issues
May 6, 2025
konstantin-msft
approved these changes
May 6, 2025
shylasummers
approved these changes
May 6, 2025
jo-arroyo
pushed a commit
that referenced
this pull request
May 19, 2025
PR to run CI against #7710 and get it merged into dev. Thanks @rm-eth-a-n for making the changes --------- Co-authored-by: rm-eth-a-n <ethan.pearce@rightmove.co.uk> Co-authored-by: Herman Jensen <herman.jensen@intility.no>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR to run CI against #7710 and get it merged into dev. Thanks @rm-eth-a-n for making the changes