Notify other open tabs of updates to localStorage #7550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tion-library-for-js into localStorage-update-events
jo-arroyo
approved these changes
Feb 4, 2025
change/@azure-msal-browser-8d616d70-17b9-4549-a720-855a2874c1da.json
Outdated
Show resolved
Hide resolved
change/@azure-msal-common-c1d96db0-db2f-4c63-918b-2da95279ee16.json
Outdated
Show resolved
Hide resolved
Co-authored-by: Jo Arroyo <joarroyo@microsoft.com>
…AD/microsoft-authentication-library-for-js into localStorage-update-events
sameerag
reviewed
Feb 4, 2025
| return; | ||
| } | ||
|
|
||
| if (context && context !== this.clientId) { |
There was a problem hiding this comment.
Is it expected to reload if clientId changes? Is it not possible for multiple apps to be in same frame (some apps do this)?
There was a problem hiding this comment.
No, the in-memory cache should contain only the cache entries that belong to its own clientId, it will ignore broadcasts coming from other clientIds. In the case where an app has multiple clientIds in the same frame each one will have its own listener and handle messages from its respective instance in the other tab.
sameerag
approved these changes
Feb 4, 2025
konstantin-msft
approved these changes
Feb 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In v4 we added encryption of localStorage entries, which also makes use of an in-memory cache to avoid constantly decrypting localStorage. This had the side effect of creating scenarios where multiple open tabs may have diverging cache states until they refresh and resync with localStorage. This PR adds broadcasting of localStorage updates to notify other open tabs or other instances of MSAL they should pull the latest changes into their respective in-memory cache objects.
On a related note: This PR also implements broadcasting for the Account Added and Account Removed events since these can no longer rely on the localStorage update events due to those values now being encrypted.