Maven integration, 0.20.5 update, IP whitelist, CORS support #6
Conversation
|
I am interested in this PR and I am curious if it will be merged eventually. Here is the motivation. I am working on sending the 'WWW-Authorize' header:
It works nicely. I am looking forward to your help merging all this upstream eventually. Thanks! |
|
@hmalphettes Nice! |
|
Hi, I am very sorry for being so unresponsive lately. I do have a lot of thing going over my head, like organizing 2 conferences and (ironically) the local elasticsearch usergroup went far bigger over the last month, which eats a lot of my free time. I would like to merge the pull request in full, but that would mean that I have to do the release work (e.g. finding a new download location now that github has closed theirs) and stuff, which I really cannot do before the middle of may (even my evenings are planned out until then). On top of that, I don't really use this plugin in production, so it kind of comes very late when I do manage to write a line of code in my free time. If one of you wants to take over maintainership, I'll happily promote your fork as the "now official" fork. Regards, |
|
@skade If you don't mind you could give me push access to your repo and I'll do the merge cause the "now official fork" won't work for google search etc ;). Although my time is limited too - a lot! ;) - I'm using this plugin in production and we'll also migrate to 0.90 if it gets released. Publishing the plugin is indeed a pain now with github. One could use my maven repo hack https://github.com/karussell/mvnrepo or the new kid on the block bintray.com |
|
I just added you both. Decide on the maven repo at your discretion :). Not a lot of time is okay, I just don't want to be further blocking people on their work. |
Maven integration, 0.20.5 update, IP whitelist, CORS support
|
Thanks! BTW: not yet tested - I'll do this on monday! |
|
Thanks @skade and @karussell: my turn to apologize for not reacting faster. I am looking forward to this! |
|
I had some success with bintray. And the branches where this is built.
|
|
tested the plugin after upgrade to ES 0.90.0 Thanks to @hmalphettes and @spinscale who made the header changes into the lastest elasticsearch (1.0 IMO) |
Some more info here #5
When reviewing my own code: authenication is enabled by default. Is that okay?
Also regarding the IP whitelisting: For load balancing one needs to grab the xForward header instead of the host. But I couldn't get this to work (for AWS) although the property "X-Forwarded-For" should be correct. Probably elasticsearch removes this from the request or whatever :/