PoC: rip out the allocator API #33
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Alternative to #31 |
AlexWaygood
reviewed
Dec 22, 2023
Tools/clinic/clinic.py
Outdated
Comment on lines
6337
to
6338
| lines = [p.render_docstring() + "\n" for p in params if p.docstring] | ||
| return "".join(lines) |
There was a problem hiding this comment.
Suggested change
| lines = [p.render_docstring() + "\n" for p in params if p.docstring] | |
| return "".join(lines) | |
| return "".join(p.render_docstring() + "\n" for p in params if p.docstring) |
We could even just get rid of this method and inline the call: it's only called in one place.
There was a problem hiding this comment.
OTOH, the method name increases the readability slightly.
There was a problem hiding this comment.
Sure, we can keep it as a separate method!
…APIs Replace the internal accumulator APIs by using lists of strings and join(). Yak-shaving for separating out formatting code into a separate file.
AlexWaygood
reviewed
Dec 22, 2023
Comment on lines
+1803
to
+1805
| out.append(s.format(f.full_name, count_min, count_max)) | ||
| out.append(' goto exit;\n') | ||
| out.append("}") |
There was a problem hiding this comment.
Suggested change
| out.append(s.format(f.full_name, count_min, count_max)) | |
| out.append(' goto exit;\n') | |
| out.append("}") | |
| out.extend([ | |
| s.format(f.full_name, count_min, count_max), | |
| ' goto exit;\n', | |
| '}', | |
| ]) |
There was a problem hiding this comment.
Hm, I prefer the existing variant.
There was a problem hiding this comment.
Fair enough, I don't feel strongly! The existing variant is fine
8eae4f0 to
cb85794
Compare
|
(I'll incorporate your latest suggestions over there) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.