8000 #nullable enable remove extra empty line by Zombach · Pull Request #2214 · App-vNext/Polly · GitHub
[go: up one dir, main page]
Skip to content

#nullable enable remove extra empty line#2214

Merged
martincostello merged 1 commit intoApp-vNext:mainfrom
Zombach:zombach/remove-extra-empty-line
Jul 20, 2024
Merged

#nullable enable remove extra empty line#2214
martincostello merged 1 commit intoApp-vNext:mainfrom
Zombach:zombach/remove-extra-empty-line

Conversation

@Zombach
Copy link
Contributor
@Zombach Zombach commented Jul 19, 2024

Pull Request

The issue or feature being addressed

Code alignment.

Details on the issue fix or feature implementation

In different places a different style is used, somewhere an empty line is used, somewhere it is not.
But for the most part there is no empty line after ##nullable

Confirm the following

  • I started this PR by branching from the head of the default branch
  • I have targeted the PR to merge into the default branch
  • I have included unit tests for the issue/feature
  • I have successfully run a local build

@Zombach Zombach changed the title #nullable enable remove extra space #nullable enable remove extra empty line Jul 19, 2024
@codecov
Copy link
codecov bot commented Jul 19, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.89%. Comparing base (ab2ffa4) to head (1393ce0).

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #2214   +/-   ##
=======================================
  Coverage   83.89%   83.89%           
=======================================
  Files         313      313           
  Lines        7179     7179           
  Branches     1060     1060           
=======================================
  Hits         6023     6023           
  Misses        785      785           
  Partials      371      371
Flag Coverage Δ
linux 83.89% <ø> (ø)
macos 74.57% <ø> (-9.33%) ⬇️
windows 83.89% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@martincostello martincostello enabled auto-merge (squash) July 20, 2024 06:36
@martincostello martincostello disabled auto-merge July 20, 2024 06:36
@martincostello martincostello enabled auto-merge (squash) July 20, 2024 06:37
@martincostello martincostello merged commit 8776447 into App-vNext:main Jul 20, 2024
@Zombach Zombach deleted the zombach/remove-extra-empty-line branch July 20, 2024 06:52
@dependabot dependabot bot mentioned this pull request Jul 23, 2025
Closed
This was referenced Jul 30, 2025
Merged
Closed
Merged
@dependabot dependabot bot mentioned this pull request Aug 18, 2025
Closed
This was referenced Aug 26, 2025
Closed
Closed
@dependabot dependabot bot mentioned this pull request Sep 2, 2025
Closed
This was referenced Sep 29, 2025
Open
Closed
Closed
Merged
@dependabot dependabot bot mentioned this pull request Oct 27, 2025
Closed
@dependabot dependabot bot mentioned this pull request Nov 24, 2025
Open
This was referenced Dec 8, 2025
Open
Closed
This was referenced Dec 15, 2025
Closed
Merged
@dependabot dependabot bot mentioned this pull request Jan 1, 2026
Open
This was referenced Jan 16, 2026
Open
Merged
This was referenced Jan 22, 2026
Merged
Merged
Closed
@dependabot dependabot bot mentioned this pull request Feb 16, 2026
Merged
This was referenced Mar 5, 2026
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@martincostello martincostello martincostello approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Zombach @martincostello
0