Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1923 +/- ##
=======================================
Coverage 84.79% 84.79%
=======================================
Files 312 312
Lines 6893 6893
Branches 1056 1056
=======================================
Hits 5845 5845
Misses 839 839
Partials 209 209
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
martincostello
approved these changes
Jan 25, 2024
Contributor
|
@martintmk Would it make sense to turn the public interface IChaosManager
{
ValueTask<bool> IsChaosEnabled(ResilienceContext context);
ValueTask<double> GetInjectionRate(ResilienceContext context);
} |
Contributor
Author
I did not use it because in the code samples there was no async at all. But it can make the second sample little cleaner. Let me try it. |
This was referenced Aug 26, 2025
This was referenced Sep 29, 2025
This was referenced Dec 8, 2025
This was referenced Jan 16, 2026
This was referenced Mar 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on Gi
6881
tHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details on the issue fix or feature implementation
Add section about how to apply chaos selectively.
Confirm the following