Clean duplications around disposing the pipelines#1530
Merged
Conversation
martincostello
approved these changes
Aug 31, 2023
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1530 +/- ##
==========================================
- Coverage 83.99% 83.93% -0.06%
==========================================
Files 279 279
Lines 6547 6523 -24
Branches 1023 1017 -6
==========================================
- Hits 5499 5475 -24
Misses 839 839
Partials 209 209
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
This was referenced Sep 29, 2025
This was referenced Jan 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details on the issue fix or feature implementation
Internally,
PipelineComponentimplemented bothIDisposableandIAsyncDisposablethat caused some duplications. Now it only implementsIAsyncDisposable.The registry still implements
IDisposableandIAsyncDisposablefor ease of use. We can afford sync-over-async because in most scenariosDisposeAsyncwill have sync implementation anyway.Confirm the following