8000 [DI] use Symfony and PSR-11 container by TomasVotruba · Pull Request #880 · ApiGen/ApiGen · GitHub
[go: up one dir, main page]
Skip to content

[DI] use Symfony and PSR-11 container #880

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 21 commits into from
Jun 9, 2017
Merged

[DI] use Symfony and PSR-11 container #880

merged 21 commits into from
Jun 9, 2017

Conversation

TomasVotruba
Copy link
Contributor
@TomasVotruba TomasVotruba commented Jun 7, 2017 •
edited
Loading

Thanks for the idea @mhujer

I need bit help with this. Looks like only classes can be autowired, not interfaces: https://travis-ci.org/ApiGen/ApiGen/builds/240583095#L302 Which makes me sad, because breaks inversion of control.

Might be caused by this: symfony/symfony#22295

Is that right, or am I doing something wrong?

Why?

  • This will open-up the whole world to work with the code.
  • It makes advantages of PSR-11 container - simple to tune or replace.
  • It makes it easier to develop and add new services thanks to Symfony 3.3+ DI features

@TomasVotruba
Copy link
Contributor Author

It might be related also to symfony/symfony#22254, which makes more sense.

@TomasVotruba TomasVotruba changed the title [WIP][SymfonyDI] experiment [DI] use Symfony nad PSR-11 container Jun 9, 2017
@TomasVotruba TomasVotruba changed the title [DI] use Symfony nad PSR-11 container [DI] use Symfony and PSR-11 container Jun 9, 2017
@TomasVotruba TomasVotruba merged commit 8513153 into master Jun 9, 2017
@TomasVotruba TomasVotruba deleted the di branch June 9, 2017 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@TomasVotruba
0