Database.query() rows as AttrDict via AttrDictRowFactory#13
Closed
Database.query() rows as AttrDict via AttrDictRowFactory#13
Conversation
dd78929 to
b3b1beb
Compare
Contributor
|
I like this functionality, but maybe it would be more compelling if it was in a separate apswutils-ext (or something) lib? i.e. show how to extend apswutils with new libs. Also, that would allow us to remove the dep on fastcore, which currently isn't used (except as a dev requirement in index.ipynb. which afaict could be easily removed. wdyt? |
Contributor
Author
|
That sounds really good, thanks for the catch on dependencies. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds new row_tracer called
AttrDictRowFactorythat returns results as an AttrDict instead of a dict.Benefits of this approach:
dictso we aren't breaking things downstream