update to 1.62.2 #14
update to 1.62.2 #14
Conversation
| - pip | ||
| - setuptools | ||
| - wheel | ||
| - protobuf 3.20.3 |
There was a problem hiding this comment.
That's interesting... grpcio_tools "vendors" protobuf (https://github.com/grpc/grpc/blob/v1.62.2/tools/distrib/python/grpcio_tools/setup.py#L193-L200). Fedora patches that so that it uses the system protobuf instead: https://src.fedoraproject.org/rpms/grpc/blob/rawhide/f/grpc.spec#_758.
They also hardcode C++14 (https://github.com/grpc/grpc/blob/v1.62.2/tools/distrib/python/grpcio_tools/setup.py#L140-L151) (though I don't think it matters here).
There was a problem hiding this comment.
third_party/abseil-cpp is also vendored, https://github.com/grpc/grpc/tree/v1.62.2/third_party
There was a problem hiding this comment.
Added patch to "unvendor" protobuf and abseil. I did not enable it for windows though as I still had issues and do not wish to spend a large amount of time on this (i.e. deferring to later). But, that is still an improvement from before.
There was a problem hiding this comment.
That's perfect @cbouss. Thanks a lot for giving it a try! Linux + macOS is already a good start.
Linter check found the following problems:ERROR conda.cli.main_run:execute(125): `conda run conda-lint /tmp/abs_62l6n05i2o/clone` failed. (See above for error) The following problems have been found:===== WARNINGS =====
|
Linter check found the following problems:ERROR conda.cli.main_run:execute(125): `conda run conda-lint /tmp/abs_3bz2w07q7t/clone` failed. (See above for error) The following problems have been found:===== WARNINGS =====
|
Linter check found the following problems:ERROR conda.cli.main_run:execute(125): `conda run conda-lint /tmp/abs_acg4ao_bx8/clone` failed. (See above for error) The following problems have been found:===== WARNINGS =====
|
Linter check found the following problems:ERROR conda.cli.main_run:execute(125): `conda run conda-lint /tmp/abs_cel6ejcmqc/clone` failed. (See above for error) The following problems have been found:===== WARNINGS =====
|
Linter check found the following problems:ERROR conda.cli.main_run:execute(125): `conda run conda-lint /tmp/abs_850956vql2/clone` failed. (See above for error) The following problems have been found:===== WARNINGS =====
|
Linter check found the following problems:ERROR conda.cli.main_run:execute(125): `conda run conda-lint /tmp/abs_074jkvkg_m/clone` failed. (See above for error) The following problems have been found:===== WARNINGS =====
|
Linter check found the following problems:ERROR conda.cli.main_run:execute(125): `conda run conda-lint /tmp/abs_9cicoz50d4/clone` failed. (See above for error) The following problems have been found:===== WARNINGS =====
|
Linter check found the following problems:ERROR conda.cli.main_run:execute(125): `conda run conda-lint /tmp/abs_5cv0wz06p1/clone` failed. (See above for error) The following problems have been found:===== WARNINGS =====
|
Linter check found the following problems:ERROR conda.cli.main_run:execute(125): `conda run conda-lint /tmp/abs_dcjrw_5vf0/clone` failed. (See above for error) The following problems have been found:===== WARNINGS =====
===== ERRORS =====
|
Linter check found the following problems:ERROR conda.cli.main_run:execute(125): `conda run conda-lint /tmp/abs_acpk_ee9hh/clone` failed. (See above for error) The following problems have been found:===== WARNINGS =====
===== ERRORS =====
|
recipe/meta.yaml
Outdated
| - cython | ||
| - libabseil 20240116.2 | ||
| - libprotobuf 4.25.3 | ||
| - protobuf 4.25.3 |
There was a problem hiding this comment.
From what I have seen, protobuf (the python package) is not required at build time.
recipe/meta.yaml
Outdated
| - python | ||
| # through run_exports | ||
| - libabseil |
There was a problem hiding this comment.
libabseil is not needed. The only abseil type used directly is absl::string_view (https://github.com/grpc/grpc/blob/master/tools/distrib/python/grpcio_tools/grpc_tools/main.cc#L114-L121) which is an alias to std::string_view in our case. This means that the library will use the std symbols and not the abseil symbols:
(test) jcmorin-mac-anac:work jcmorin$ nm ../_h_env/lib/python3.12/site-packages/grpc_tools/_protoc_compiler.cpython-312-darwin.so | c++filt | grep -e RecordError -e RecordWarning
000000000002492c t grpc_tools::internal::ErrorCollectorImpl::RecordError(std::__1::basic_string_view<char, std::__1::char_traits<char>>, int, int, std::__1::basic_string_view<char, std::__1::char_traits<char>>)
0000000000024b34 t grpc_tools::internal::ErrorCollectorImpl::RecordWarning(std::__1::basic_string_view<char, std::__1::char_traits<char>>, int, int, std::__1::basic_string_view<char, std::__1::char_traits<char>>)
So we can use ignore_run_exports on libabseil to ignore the DSO warning.
There was a problem hiding this comment.
As grpcio-tools relies on -std=c++14 https://github.com/grpc/grpc/blob/v1.62.2/tools/distrib/python/grpcio_tools/setup.py#L93 then libabseil is not needed but for c++17 and protobuf >=22 I guess it will be required, see opencv/opencv#24369
recipe/meta.yaml
Outdated
| - python | ||
| # through run_exports | ||
| - libabseil |
There was a problem hiding this comment.
As grpcio-tools relies on -std=c++14 https://github.com/grpc/grpc/blob/v1.62.2/tools/distrib/python/grpcio_tools/setup.py#L93 then libabseil is not needed but for c++17 and protobuf >=22 I guess it will be required, see opencv/opencv#24369
Linter check found the following problems:ERROR conda.cli.main_run:execute(125): `conda run conda-lint /tmp/abs_22p4qufi95/clone` failed. (See above for error) The following problems have been found:===== WARNINGS =====
===== ERRORS =====
|
The inverse in this case @skupr-anaconda. Also Charles patched up grpcio-tools to compiled with C++17. TO add more details, grpcio-tools today only needs |
There was a problem hiding this comment.
Great work @cbouss and thank you for taking the time to unvendor stuff on linux and macos!
Linter check found the following problems:ERROR conda.cli.main_run:execute(125): `conda run conda-lint /tmp/abs_baoq3jny9s/clone` failed. (See above for error) The following problems have been found:===== WARNINGS =====
===== ERRORS =====
|
grpcio-tools 1.62.2
Destination channel: main
Links
Added patch to "unvendor" protobuf and abseil. I did not enable it for windows though as I still had issues and do not wish to spend a large amount of time on this (i.e. deferring to later). But, that is still an improvement from before.