-
Notifications
You must be signed in to change notification settings - Fork 68
{{ message }}
Do not use fixed sed script path#261
Open
kie
8000
nanstewart wants to merge 3 commits intoAlternC:mainfrom
Open
Conversation
Contributor
|
Hello I've tried to rebase over main to get an up to date PR, but get some conflict. I'll clean at least this PR to be more accurate and reflect about to apply it or not |
Using a fixed string could allow for abuse by anyone who has access to /tmp. One could place a symbolic link to any file to cause it to be overwritten when alternc.install is run.
43f3e85 to
ad19402
Compare
* SED_SCRIPT is provided as second argument to all install.d/ scripts Follow exit status as explained at https://www.gnu.org/software/bash/manual/html_node/Exit-Status.html
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use mktemp to get the filename for storing the templating script
Using a fixed string could allow for abuse by anyone who has access to /tmp. One could place a symbolic link to any file to cause it to be overwritten when alternc.install is run.
The location of the sed script is passed as a second argument to scripts in /usr/lib/share/alternc/install.d when the template hook is called.