8000 Use `in` for substring check by etienne-napoleone · Pull Request #35 · AllAlgorithms/python · GitHub
[go: up one dir, main page]
Skip to content

Use in for substring check #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 4, 2018
Merged

Use in for substring check #35

merged 1 commit into from
Oct 4, 2018

Conversation

etienne-napoleone
Copy link
Contributor
@etienne-napoleone etienne-napoleone commented Oct 3, 2018 •
edited
Loading

Pros:

  • faster
  • more readable

@etienne-napoleone etienne-napoleone changed the title Use in for substring check Use in for substring check Oct 3, 2018
@abranhe
Copy link
Member
abranhe commented Oct 4, 2018

Can you create a new repl.it/languages/python making a simple Benchmark for this?

@etienne-napoleone
Copy link
Contributor Author

Sure! Here you go

@sanghisha145
Copy link

I would like to work on this.

@abranhe
Copy link
Member
abranhe commented Oct 4, 2018

Sure! Here you go

Thank you, @etienne-napoleone it will be merged!

@abranhe abranhe merged commit 02ffd4d into AllAlgorithms:master Oct 4, 2018
@etienne-napoleone etienne-napoleone deleted the patch-1 branch October 5, 2018 03:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@etienne-napoleone @abranhe @sanghisha145
0