8000 Integrated cordova-plugin-buildinfo as a local plugin by RohitKushvaha01 · Pull Request #1387 · Acode-Foundation/Acode · GitHub
[go: up one dir, main page]

Skip to content

Integrated cordova-plugin-buildinfo as a local plugin #1387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 26, 2025

Conversation

RohitKushvaha01
Copy link
Collaborator
@RohitKushvaha01 RohitKushvaha01 commented Jun 23, 2025

Closes #1377

removed _BUILDINFO_TIMESTAMP

Copy link
Collaborator
@bajrangCoder bajrangCoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't there any other way

Copy link
Collaborator
@UnschooledGamer UnschooledGamer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine for now!

@RohitKushvaha01
Copy link
Collaborator Author

Isn't there any other way

We could remove the plugin entirely, but other parts of the code might still depend on it. That’s why I cloned it locally and made the changes instead.

@UnschooledGamer
Copy link
Collaborator

Or better yet, F-Droid implemented SOURCE_DATE_EPOCH environment variable, based on the last commit so you could try to use that or, if not set, fallback to the current solution.

Could do the above ^^

OR fallback commit date or current date as last option.

I wonder why it started failing recently 🤔

@RohitKushvaha01
Copy link
Collaborator Author
RohitKushvaha01 commented Jun 23, 2025

Or better yet, F-Droid implemented SOURCE_DATE_EPOCH environment variable, based on the last commit so you could try to use that or, if not set, fallback to the current solution.

Could do the above ^^

OR fallback commit date or current date as last option.

I wonder why it started failing recently 🤔

No need to handle the date,I just removed it since it was never actually used in Acode anyway.
As for the recent failures, they started happening since the buildinfo plugin was added it just wasn’t reported until now. (this is a year old issue)

see: https://verification.f-droid.org/packages/com.foxdebug.acode/

@deadlyjack
Copy link
Collaborator
deadlyjack commented Jun 24, 2025

May be you can check the usage and implement the same methods in system plugin if possible or remove source for other platforms like windows, IOS as it's not being used.

@UnschooledGamer
Copy link
Collaborator

Either Way implementing methods in system Plugin or not KEEP the LICENCE file & Credits along with them.

@RohitKushvaha01 RohitKushvaha01 merged commit 880bd7b into Acode-Foundation:main Jun 26, 2025
2 checks passed
@licaon-kter
Copy link

@UnschooledGamer we started making these viable recently

see: https://f-droid.org/2025/05/01/twif.html

and https://f-droid.org/2025/05/21/making-reproducible-builds-visible.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove some non-determinism
5 participants
0