8000 Nuvoton: Set M252 Flash internal size for kv store test by cyliangtw · Pull Request #13531 · ARMmbed/mbed-os · GitHub
[go: up one dir, main page]
Skip to content

Nuvoton: Set M252 Flash internal size for kv store test #13531

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 3, 2020
Merged

Nuvoton: Set M252 Flash internal size for kv store test #13531

merged 1 commit into from
Sep 3, 2020

Conversation

cyliangtw
Copy link
Contributor

The kvstore test uses last two sectors of flash for its test, but M252’s sector size is only 512 bytes and is too small for this test. Thus, to set M252 Flash internal default size as 8KB for kv store test in /tdb_internal/mbed_lib.json .

Summary of changes

Impact of changes

Migration actions required

Documentation

Pull request type 

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@MarceloSalazar

@ciarmcom ciarmcom added the release-type: patch Indentifies a PR as containing just a patch label Sep 2, 2020
@ciarmcom ciarmcom requested review from MarceloSalazar and a team September 2, 2020 12:30
@ciarmcom
Copy link
Member
ciarmcom commented Sep 2, 2020

@cyliangtw, thank you for your changes.
@MarceloSalazar @ARMmbed/mbed-os-maintainers please review.

MarceloSalazar
MarceloSalazar approved these changes Sep 2, 2020
View reviewed changes
Copy link
@MarceloSalazar MarceloSalazar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR.
Approving, assuming that the kvstore test cases pass

@mergify mergify bot added needs: CI and removed needs: review labels Sep 2, 2020
@0xc0170
Copy link
Contributor
0xc0170 commented Sep 2, 2020

CI started

@mbed-ci
Copy link
mbed-ci commented Sep 2, 2020

Jenkins CI Test : ✔️ SUCCESS

Build Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_build-ARM ✔️
jenkins-ci/mbed-os-ci_build-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_dynamic-memory-usage ✔️
jenkins-ci/mbed-os-ci_cloud-client-pytest ✔️
jenkins-ci/mbed-os-ci_greentea-test ✔️

@0xc0170 0xc0170 merged commit 54f0f56 into ARMmbed:master Sep 3, 2020
@mergify mergify bot removed the ready for merge label Sep 3, 2020
@mbedmain mbedmain added release-version: 6.3.0 Release-pending and removed release-type: patch Indentifies a PR as containing just a patch Release-pending labels Sep 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarceloSalazar MarceloSalazar MarceloSalazar approved these changes

@0xc0170 0xc0170 57B6 0xc0170 approved these changes

Assignees
No one assigned
Labels
release-version: 6.3.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@cyliangtw @ciarmcom @0xc0170 @mbed-ci @MarceloSalazar @mbedmain
0