8000 Daniel info panel2 by dkrasner · Pull Request #147 · APrioriInvestments/object_database · GitHub
[go: up one dir, main page]
Skip to content

Daniel info panel2 #147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
dkrasner wants to merge 9 commits into
base: daniel-devtools-cleanup
Choose a base branch
from
Open

Daniel info panel2 #147

dkrasner wants to merge 9 commits into from

Conversation

@dkrasner
Copy link
Contributor
@dkrasner dkrasner commented Aug 7, 2023

Motivation and Context

This PR adds a V0 cell arguments data and ability to change these 'live' to the devtools info panel. [Note: this PR is sitting on top of #145 ]

Approach

You can now see all the arguments passed into the cell, ie the data/args dict gets passed to devtools. This data gets passed to devtools via info window message API request as seen here and here .

When arg input values are changed (shift+enter), a message is sent via background to the content script, which passes it on to the CellHandler.

How Has This Been Tested?

In the devtools cells panel. This data gets passed to devtools via info window message API request as seen here. This in turn updates the args and rebuilds the cell, as seen here

[NOTE: this is a v0 here and there are issues as not all args are being updated properly, tbd]

Screenshots or console output (if appropriate)

Screen.Recording.2023-08-07.at.12.40.57.PM.mov

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@dkrasner dkrasner added the enhancement New feature or request label Aug 7, 2023
@dkrasner dkrasner requested a review from braxtonmckee August 7, 2023 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@braxtonmckee braxtonmckee Awaiting requested review from braxtonmckee

Assignees

No one assigned

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dkrasner
0