8000 Exclude the yanked package in the requirement file and fix the curren… by kanglant · Pull Request #3027 · AI-Hypercomputer/maxtext · GitHub
[go: up one dir, main page]
Skip to content

Exclude the yanked package in the requirement file and fix the curren… #3027

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
kanglant wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Exclude the yanked package in the requirement file and fix the curren… #3027

kanglant wants to merge 1 commit into from
+32 −22

Conversation

@kanglant
Copy link
Collaborator
@kanglant kanglant commented Jan 28, 2026

…t breakage due to the missing of jaraco-functools

Description

We pinned some packages in the requirement file to avoid uv resolve to yanked versions. This PR exclude the yanked versions instead for more flexibility.

The tpu-requirements.txt is generated by running seed-env --local-requirements=dependencies/requirements/base_requirements/tpu-base-requirements.txt --host-name=MaxText --seed-commit=3412cca20be99ddb96916dea2268220a420fdada --python-version=3.12 --requirements-txt=tpu-requirements.txt --output-dir=generated_tpu_artifacts where the --seed-commit=3412cca20be99ddb96916dea2268220a420fdada is the commit where we get JAX 0.8.1's requirement lock file.

Checklist

Before submitting this PR, please make sure (put X in square brackets):

  • I have performed a self-review of my code. For an optional AI review, add the gemini-review label.
  • I have necessary comments in my code, particularly in hard-to-understand areas.
  • I have run end-to-end tests tests and provided workload links above if applicable.
  • I have made or will make corresponding changes to the doc if needed, including adding new documentation pages to the relevant Table of Contents (toctree directive) as explained in our documentation.

@kanglant kanglant marked this pull request as ready for review January 28, 2026 07:32
@kanglant kanglant force-pushed the exclude-yanked branch 2 times, most recently from 3dd44fb to 50b8181 Compare January 28, 2026 08:20
@kanglant kanglant marked this pull request as draft January 28, 2026 08:43
@codecov
Copy link
codecov bot commented Jan 28, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@kanglant kanglant force-pushed the exclude-yanked branch 2 times, most recently from 802281d to b844bb8 Compare January 28, 2026 09:13
@kanglant
Exclude the yanked package in the requirement file and fix the curren…
ba1bd97 
…t breakage due to the missing of jaraco-functools
@kanglant kanglant marked this pull request as ready for review January 28, 2026 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

bvandermoon Awaiting requested review from bvandermoon bvandermoon is a code owner

@parambole parambole Awaiting requested review from parambole parambole is a code owner

@richjames0 richjames0 Awaiting requested review from richjames0 richjames0 is a code owner

@shralex shralex Awaiting requested review from shralex shralex is a code owner

@gobbleturk gobbleturk Awaiting requested review from gobbleturk

@khatwanimohit khatwanimohit Awaiting requested review from khatwanimohit

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@kanglant
0