upgrade libgit2 and release as 8w-2023-01-30 #28
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The url::scp::invalid_addresses test attempts to test an invalid IPv6 address. It does no 10000 t, it calls the regular URL parsing function which treats it like a possibly invalid scheme.
Provide our own url parser, so that we can handle Google Code's "fun" URLs that have a userinfo with an `@` in it. 😢
Enforce the RFC for other protocols; Google's questionable choices about malformed SSH protocols shouldn't impact our ability to properly parse HTTPS.
I want to push a commit by OID to a remote branch. Currently, push parses the refspecs such that the source must be the name of a ref (it uses git_reference_name_to_id to resolve it). This commit changes it so push uses git_revparse_single to resolve the source of the refspec. This allows for OIDs or other revs (e.g. `HEAD~2`) to be pushed.
In commit 6bb3587 ("clone: set refs/remotes/origin/HEAD to default branch when branch is specified, attempt 2") libgit2 was changed to set the default remote branch when one was copied. But it makes update_head_to_branch() return an error if the origin doesn't even *have* a HEAD in the first place, since git_remote_default_branch() will fail. That's entirely wrong, and means that you cannot do "git_clone()" of a particular branch on a remote repository when that remote doesn't have a default branch at all. So don't set the error code. Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
ensure the needed wincrypt.h is included
Signed-off-by: Sven Strickroth <email@cs-ware.de>
GitHub has deprecated macOS 10.15; move to their new macOS 11 build servers.
We previously (correctly) cleaned up the git daemon and SSH server, but failed to clean up our bespoke HTTP server and HTTP proxies. Capture their PIDs on process creation and kill them when we shut down.
CI Improvements
Only allow the remote default branch checking to fail when the remote default branch doesn't exist (`git_remote__default_branch` returns `GIT_ENOTFOUND`). If there was any other type of error - for example, an allocation failure - we should not swallow that and continue to fail. This allows us to support the case when a remote has not advertised a HEAD -- this is possible, for example, when the remote has constrained the caller to a particular namespace. But other remote failures remain as failures.
Test that we can successfully clone a repository that is namespace scoped to a bare repository locally. We need not specify a checkout branch in this case (obviously, since we do not check anything out in a bare clone).
Test that we can successfully clone a repository that is namespace scoped on the remote and does not advertise a HEAD. To do this, we must specify the branch to checkout.
winhttp: support long custom headers
…IN32_LEAN_AND_MEAN fix compile on Windows with -DWIN32_LEAN_AND_MEAN
Fixes libgit2#6365 : Uppercase windows.h include fails build in case-sensitive OS
Fix memory leak
Delete create.c.bak
Don't fail the whole clone if you can't find a default branch
Actually `cl_skip` the sha256 tests when we're not compiled for sha256, instead of passing them.
…ookup-error-code libgit2#6366: When a worktree is missing, return GIT_ENOTFOUND.
Fixes libgit2#6433: git_submodule_update fails to update configured but missing submodule
`git_clone` checks for existence of (non-empty) directories that would clash with what is about to be cloned. This is problematic when cloning submodules since they make sense in the context of a parent module, so they should not use the current working dir. Since in `git_submodule_update` we clone the submodule only when it is not yet initialized we do not need to perform directory checks.
ci: update version numbers of actions
transport: fix capabilities calculation
thread: avoid warnings when building without threads
push: revparse refspec source, so you can push things that are not refs
211c971 attempts to use the parsed OID but inverted the arguments to `git_oid_cpy`.
push: use resolved oid as the source
It conflicts with NetBSD's in its libc. Closes libgit2#6457
The builtin hash uses the code verbatim from rfc6234, including prototypes for functions that we don't use (like hmac). Remove all unused prototypes to avoid collisions with things that an operating system might provide (like hmac).
src: hide unused hmac() prototype
Update to the latest main version of clar, which includes improved xml summary output.
Abstract time counter for tests; use gettimeofday on Unix and GetTickCount on Windows.
tests: update clar test runner
When the dependent jobs fail -- possibly due to test failures -- we should still produce the job summary that shows those test failures.
ci: always create test summaries, even on failure
Upgrade libgit2 with support for 8thwall cloud editor.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the result of a rebase on top of upstream main. g8 tests pass and cloud editor continues to work as expected locally.