Fix duplicate timeupdate events in Text Track Code

Ahmad-S792 · Ahmad Saleem · commit afdf40ad5538 · 2023-01-18T04:21:41.000-08:00
Fix duplicate timeupdate events in Text Track Code https://bugs.webkit.org/show_bug.cgi?id=250741 Reviewed by Eric Carlson. Merge - https://chromium.googlesource.com/chromium/blink/+/fd62a2259d085146f7fb275f99edb80e0e80243b This change prevents duplicate timeupdate events caused by the text track code. The comment above the call indicates that the timeupdate event should have the same restrictions as the normal periodic timeupdate event. By changing the parameter passed to scheduleTimeupdateEvent() to true, the event rate limiting guards are properly applied to this call and duplicate events won't fire. * Source/WebCore/html/HTMLMediaElement.cpp: (HTMLMediaElement::updateActiveTextTrackCues): Update 'scheduleTimeUpdateEvent' to 'true' to have event rate limit Canonical link: https://commits.webkit.org/259023@main
diff --git a/Source/WebCore/html/HTMLMediaElement.cpp b/Source/WebCore/html/HTMLMediaElement.cpp
@@ -1,5 +1,6 @@
 /*
- * Copyright (C) 2007-2022 Apple Inc. All rights reserved.
+ * Copyright (C) 2007-2023 Apple Inc. All rights reserved.
+ * Copyright (C) 2014 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
@@ -1773,7 +1774,7 @@ void HTMLMediaElement::updateActiveTextTrackCues(const MediaTime& movieTime)
     // fired as part of the overall process of changing the current playback
     // position.)
     if (!m_paused && m_lastSeekTime <= lastTime)
-        scheduleTimeupdateEvent(false);
+        scheduleTimeupdateEvent(true);
 
     // Explicitly cache vector sizes, as their content is constant from here.
     size_t currentCuesSize = currentCues.size();
