8000 FileSystemSyncAccessHandle::close should be idempotent · WebKit/WebKit@af4870c · GitHub
[go: up one dir, main page]
Skip to content

Commit af4870c

Browse files
szewaiszewai
committed
FileSystemSyncAccessHandle::close should be idempotent
https://bugs.webkit.org/show_bug.cgi?id=250342 rdar://104049062 Reviewed by Tim Nguyen. It should not throw error on second call. * LayoutTests/imported/w3c/web-platform-tests/fs/FileSystemSyncAccessHandle-close.https.tentative.worker-expected.txt: * Source/WebCore/Modules/filesystemaccess/FileSystemSyncAccessHandle.cpp: (WebCore::FileSystemSyncAccessHandle::close): Canonical link: https://commits.webkit.org/258736@main
1 parent 9cdd3b4 commit af4870c

File tree

2 files changed

+7
-7
lines changed

2 files changed

+7
-7
lines changed

‎LayoutTests/imported/w3c/web-platform-tests/fs/FileSystemSyncAccessHandle-close.https.tentative.worker-expected.txt‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11

2-
FAIL SyncAccessHandle.close is idempotent promise_test: Unhandled rejection with value: object "InvalidStateError: AccessHandle is closed"
3-
FAIL SyncAccessHandle.read fails after SyncAccessHandle.close promise_test: Unhandled rejection with value: object "InvalidStateError: AccessHandle is closed"
4-
FAIL SyncAccessHandle.write fails after SyncAccessHandle.close promise_test: Unhandled rejection with value: object "InvalidStateError: AccessHandle is closed"
5-
FAIL SyncAccessHandle.flush fails after SyncAccessHandle.close promise_test: Unhandled rejection with value: object "InvalidStateError: AccessHandle is closed"
6-
FAIL SyncAccessHandle.getSize fails after SyncAccessHandle.close promise_test: Unhandled rejection with value: object "InvalidStateError: AccessHandle is closed"
7-
FAIL SyncAccessHandle.truncate fails after SyncAccessHandle.handle.close promise_test: Unhandled rejection with value: object "InvalidStateError: AccessHandle is closed"
2+
PASS SyncAccessHandle.close is idempotent
3+
PASS SyncAccessHandle.read fails after SyncAccessHandle.close
4+
PASS SyncAccessHandle.write fails after SyncAccessHandle.close
5+
PASS SyncAccessHandle.flush fails after SyncAccessHandle.close
6+
PASS SyncAccessHandle.getSize fails after SyncAccessHandle.close
7+
PASS SyncAccessHandle.truncate fails after SyncAccessHandle.handle.close
88

‎Source/WebCore/Modules/filesystemaccess/FileSystemSyncAccessHandle.cpp‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -87,7 +87,7 @@ ExceptionOr<void> FileSystemSyncAccessHandle::flush()
8787
ExceptionOr<void> FileSystemSyncAccessHandle::close()
8888
{
8989
if (m_isClosed)
90-
return Exception { InvalidStateError, "AccessHandle is closed"_s };
90+
return { };
9191

9292
closeInternal(ShouldNotifyBackend::Yes);
9393
return { };

0 commit comments

Comments
 (0)
0