8000 Remove SVGFEMorphologyElement.setRadius(radiusX, radiusY) · WebKit/WebKit@721874c · GitHub
[go: up one dir, main page]
Skip to content

Commit 721874c

Browse files
Ahmad-S792Ahmad Saleem
Ahmad-S792
authored and
Ahmad Saleem
committed
Remove SVGFEMorphologyElement.setRadius(radiusX, radiusY)
Remove SVGFEMorphologyElement.setRadius(radiusX, radiusY) https://bugs.webkit.org/show_bug.cgi?id=249964 Reviewed by Simon Fraser. This patch is to align WebKit with Gecko / Firefox, Blink / Chromium and Web-Specification. Merge - https://chromium.googlesource.com/chromium/blink/+/feaed7a237ae1fef5303af45d6d44429fa338fb7 This patch is to remove non-standard 'setRadius', which was only supported by WebKit based browsers and was dropped by Blink in 2014. Hence, Safari / WebKit is now only browser engine supporting it. * Source/WebCore/SVGFEMorphologyElement.h: Remove 'setRadius' * Source/WebCore/SVGFEMorphologyElement.cpp: Remove 'setRadius' function * Source/WebCore/SVGFEMorphologyElement.idl: Remove 'setRadius' attributes * LayoutTests/svg/dynamic-updates/SVGFEMorphologyElement-svgdom-radius-call.html: Rebaselined Canonical link: https://commits.webkit.org/258733@main
1 parent 3e90af4 commit 721874c

File tree

4 files changed

+7
-15
lines changed

4 files changed

+7
-15
lines changed

‎LayoutTests/svg/dynamic-updates/SVGFEMorphologyElement-svgdom-radius-call.html‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ <h1>SVG 1.1 dynamic update tests</h1>
5353
shouldBe("morphologyElement.radiusY.baseVal", "6");
5454

5555
function repaintTest() {
56-
morphologyElement.setRadius(4, 4);
56+
morphologyElement.setAttribute("radius", "4,4");
5757
shouldBe("morphologyElement.radiusX.baseVal", "4");
5858
shouldBe("morphologyElement.radiusY.baseVal", "4");
5959

‎Source/WebCore/svg/SVGFEMorphologyElement.cpp‎

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
/*
22
* Copyright (C) 2009 Dirk Schulze <krit@webkit.org>
3-
* Copyright (C) 2018-2022 Apple Inc. All rights reserved.
3+
* Copyright (C) 2018-2023 Apple Inc. All rights reserved.
4+
* Copyright (C) 2014 Google Inc. All rights reserved.
45
*
56
* This library is free software; you can redistribute it and/or
67
* modify it under the terms of the GNU Library General Public
@@ -48,13 +49,6 @@ Ref<SVGFEMorphologyElement> SVGFEMorphologyElement::create(const QualifiedName&
4849
return adoptRef(*new SVGFEMorphologyElement(tagName, document));
4950
}
5051

51-
void SVGFEMorphologyElement::setRadius(float x, float y)
52-
{
53-
m_radiusX->setBaseValInternal(x);
54-
m_radiusY->setBaseValInternal(y);
55-
updateSVGRendererForElementChange();
56-
}
57-
5852
void SVGFEMorphologyElement::parseAttribute(const QualifiedName& name, const AtomString& value)
5953
{
6054
if (name == SVGNames::operatorAttr) {

‎Source/WebCore/svg/SVGFEMorphologyElement.h‎

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
/*
22
* Copyright (C) 2009 Dirk Schulze <krit@webkit.org>
3-
* Copyright (C) 2018-2022 Apple Inc. All rights reserved.
3+
* Copyright (C) 2018-2023 Apple Inc. All rights reserved.
4+
* Copyright (C) 2014 Google Inc. All rights reserved.
45
*
56
* This library is free software; you can redistribute it and/or
67
* modify it under the terms of the GNU Library General Public
@@ -59,8 +60,6 @@ class SVGFEMorphologyElement final : public SVGFilterPrimitiveStandardAttributes
5960
public:
6061
static Ref<SVGFEMorphologyElement> create(const QualifiedName&, Document&);
6162

62-
void setRadius(float radiusX, float radiusY);
63-
6463
String in1() const { return m_in1->currentValue(); }
6564
MorphologyOperatorType svgOperator() const { return m_svgOperator->currentValue<MorphologyOperatorType>(); }
6665
float radiusX() const { return m_radiusX->currentValue(); }

‎Source/WebCore/svg/SVGFEMorphologyElement.idl‎

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
11
/*
22
* Copyright (C) 2009 Dirk Schulze <krit@webkit.org>
3+
* Copyright (C) 2023 Apple Inc. All rights reserved.
4+
* Copyright (C) 2014 Google Inc. All rights reserved.
35
*
46
* Redistribution and use in source and binary forms, with or without
57
* modification, are permitted provided that the following conditions
@@ -36,9 +38,6 @@
3638
[ImplementedAs=svgOperator] readonly attribute SVGAnimatedEnumeration operator;
3739
readonly attribute SVGAnimatedNumber radiusX;
3840
readonly attribute SVGAnimatedNumber radiusY;
39-
40-
undefined setRadius(optional unrestricted float radiusX = NaN,
41-
optional unrestricted float radiusY = NaN);
4241
};
4342

4443
SVGFEMorphologyElement includes SVGFilterPrimitiveStandardAttributes;

0 commit comments

Comments
 (0)
0