This repository was archived by the owner on Mar 9, 2026. It is now read-only.
feat: Enable server side flow control by default with the option to turn it off#231
Merged
kamalaboulhosn merged 4 commits intogoogleapis:masterfrom Nov 10, 2020
Merged
Conversation
… off This change enables sending flow control settings automatically to the server. If flow_control.max_messages > 0 or flow_control.max_bytes > 0, flow control will be enforced at the server side (in addition to the client side). This behavior is enabled by default and users who would like to opt-out of this feature --in case they encouter issues with server side flow control-- can pass in use_legacy_flow_control=True in SubscriberClient.subscribe().
… off This change enables sending flow control settings automatically to the server. If flow_control.max_messages > 0 or flow_control.max_bytes > 0, flow control will be enforced at the server side (in addition to the client side). This behavior is enabled by default and users who would like to opt-out of this feature --in case they encouter issues with server side flow control-- can pass in use_legacy_flow_control=true in subscriberclient.subscribe().
pradn
suggested changes
Nov 5, 2020
pradn
approved these changes
Nov 5, 2020
anguillanneuf
added a commit
that referenced
this pull request
Nov 10, 2020
feat: Enable server side flow control by default with the option to turn it off (#231) * Enable server side flow control by default with the option to turn it off This change enables sending flow control settings automatically to the server. If flow_control.max_messages > 0 or flow_control.max_bytes > 0, flow control will be enforced at the server side (in addition to the client side). This behavior is enabled by default and users who would like to opt-out of this feature --in case they encouter issues with server side flow control-- can pass in use_legacy_flow_control=True in SubscriberClient.subscribe(). * Enable server side flow control by default with the option to turn it off This change enables sending flow control settings automatically to the server. If flow_control.max_messages > 0 or flow_control.max_bytes > 0, flow control will be enforced at the server side (in addition to the client side). This behavior is enabled by default and users who would like to opt-out of this feature --in case they encouter issues with server side flow control-- can pass in use_legacy_flow_control=true in subscriberclient.subscribe(). Co-authored-by: Tianzi Cai <tianzi@google.com> fix: replace AssertionError with NotFound fix: add another pytest fixture in failing test remove backoff
anguillanneuf
added a commit
that referenced
this pull request
Dec 11, 2020
* fix: reorder tests * fix: increase timeout * fix: use backoff feat: Enable server side flow control by default with the option to turn it off (#231) * Enable server side flow control by default with the option to turn it off This change enables sending flow control settings automatically to the server. If flow_control.max_messages > 0 or flow_control.max_bytes > 0, flow control will be enforced at the server side (in addition to the client side). This behavior is enabled by default and users who would like to opt-out of this feature --in case they encouter issues with server side flow control-- can pass in use_legacy_flow_control=True in SubscriberClient.subscribe(). * Enable server side flow control by default with the option to turn it off This change enables sending flow control settings automatically to the server. If flow_control.max_messages > 0 or flow_control.max_bytes > 0, flow control will be enforced at the server side (in addition to the client side). This behavior is enabled by default and users who would like to opt-out of this feature --in case they encouter issues with server side flow control-- can pass in use_legacy_flow_control=true in subscriberclient.subscribe(). Co-authored-by: Tianzi Cai <tianzi@google.com> fix: replace AssertionError with NotFound fix: add another pytest fixture in failing test remove backoff * add py version in resource names * keep pulling until response is not None * use fstrings * change scope to session and set retry deadline * lint and increase timeout to 90 for dlq receive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change enables sending flow control settings automatically to the server. If flow_control.max_messages > 0 or flow_control.max_bytes > 0, flow control will be enforced at the server side (in addition to the client side).
This behavior is enabled by default and users who would like to opt-out of this feature --in case they encounter issues with server side flow control-- can pass in use_legacy_flow_control=True in SubscriberClient.subscribe().