8000 fix: adding deprecated tags to deprecated methods by hannahrogers-google · Pull Request #472 · googleapis/java-pubsub · GitHub
[go: up one dir, main page]

Skip to content

fix: adding deprecated tags to deprecated methods#472

Merged
elharo merged 45 commits intogoogleapis:masterfrom
hannahrogers-google:master
Jan 21, 2021
Merged

fix: adding deprecated tags to deprecated methods#472
elharo merged 45 commits intogoogleapis:masterfrom
hannahrogers-google:master

Conversation

@hannahrogers-google
Copy link
Contributor

Fixes #249 ☕️

Adding delivery attempt count to PubsubMessages as a message attribute,
and creating helper function to allow users to get the count without
knowing implementation details.
@hannahrogers-google hannahrogers-google requested review from a team December 23, 2020 20:15
@product-auto-label product-auto-label bot added the api: pubsub Issues related to the googleapis/java-pubsub API. label Dec 23, 2020
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Dec 23, 2020
@codecov
Copy link
codecov bot commented Dec 23, 2020

Codecov Report

Merging #472 (9ac49ea) into master (260eca5) will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #472      +/-   ##
============================================
- Coverage     79.17%   79.14%   -0.04%     
  Complexity      323      323              
============================================
  Files            21       21              
  Lines          2925     2925              
  Branches        166      166              
============================================
- Hits           2316     2315       -1     
  Misses          541      541              
- Partials         68       69       +1     
Impacted Files Coverage Δ Complexity Δ
.../com/google/cloud/pubsub/v1/MessageDispatcher.java 84.87% <0.00%> (-0.49%) 26.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 260eca5...9ac49ea. Read the comment docs.

@hannahrogers-google hannahrogers-google requested a review from a team January 6, 2021 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment