test: use header constants in unmarshaller tests #60
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
grant
approved these changes
Apr 28, 2020
|
Looks fine but looks like there are conflicts. |
|
@danbev fix the conflicts, please. |
This commit updates the http unmarshaller tests to use the constants available in lib/bindings/http/constants.js. Signed-off-by: Daniel Bevenius <daniel.bevenius@gmail.com>
a244646 to
5b89ff4
Compare
|
@fabiojose Thanks for the heads up, I've rebased and fixed the conflicts now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit updates the http unmarshaller tests to use the constants
available in
lib/bindings/http/constants.js.Signed-off-by: Daniel Bevenius daniel.bevenius@gmail.com