8000 feat(eslint-plugin): sync getFunctionHeadLoc implementation with upstream by bradzacher · Pull Request #7260 · typescript-eslint/typescript-eslint · GitHub
[go: up one dir, main page]
Skip to content

feat(eslint-plugin): sync getFunctionHeadLoc implementation with upstream #7260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 18, 2023
Merged

feat(eslint-plugin): sync getFunctionHeadLoc implementation with upstream #7260

merged 1 commit into from
Jul 18, 2023

Conversation

bradzacher
Copy link
Member

Splitting this out of #6457 to better focus the PR.
Syncs the utility from upstream giving us better coverage and alignment with ESLint core.

@bradzacher bradzacher added the enhancement New feature or request label Jul 18, 2023
@typescript-eslint
Copy link
Contributor

Thanks for the PR, @bradzacher!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify
Copy link
netlify bot commented Jul 18, 2023 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit be95293
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/64b65eefd6912b0008813bc1
😎 Deploy Preview https://deploy-preview-7260--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@nx-cloud
Copy link
nx-cloud bot commented Jul 18, 2023 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit be95293. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 35 targets

Sent with 💌 from NxCloud.

@codecov
Copy link
codecov bot commented Jul 18, 2023 •
edited
Loading

Codecov Report

Merging #7260 (be95293) into main (e5d668c) will increase coverage by 0.00%.
The diff coverage is 96.55%.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #7260   +/-   ##
=======================================
  Coverage   87.47%   87.48%           
=======================================
  Files         379      379           
  Lines       13234    13250   +16     
  Branches     3907     3911    +4     
=======================================
+ Hits        11577    11592   +15     
  Misses       1279     1279           
- Partials      378      379    +1
Flag Coverage Δ
unittest 87.48% <96.55%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...kages/eslint-plugin/src/util/getFunctionHeadLoc.ts 96.66% <96.55%> (-3.34%) ⬇️

@bradzacher bradzacher mentioned this pull request Jul 18, 2023
Merged
3 tasks
JoshuaKGoldberg
JoshuaKGoldberg approved these changes Jul 18, 2023
View reviewed changes
Copy link
Member
@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

South park style politician stamping a paper in their office

@bradzacher bradzacher merged commit f813147 into main Jul 18, 2023
@bradzacher bradzacher deleted the update-getFunctionHeadLoc branch July 18, 2023 13:30
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JoshuaKGoldberg JoshuaKGoldberg JoshuaKGoldberg approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bradzacher @JoshuaKGoldberg
0