8000 fix(eslint-plugin): [member-ordering] account for repeated names by JoshuaKGoldberg · Pull Request #6864 · typescript-eslint/typescript-eslint · GitHub
[go: up one dir, main page]
Skip to content

fix(eslint-plugin): [member-ordering] account for repeated names #6864

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 18, 2023
Merged

fix(eslint-plugin): [member-ordering] account for repeated names #6864

merged 2 commits into from
Jul 18, 2023

Conversation

JoshuaKGoldberg
Copy link
Member

PR Checklist

Overview

naturalOutOfOrder should always return false if the names being compared are the same.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify
Copy link
netlify bot commented Apr 8, 2023 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 83c62c2
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/64b669b7be076600078885b1
😎 Deploy Preview https://deploy-preview-6864--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@JoshuaKGoldberg JoshuaKGoldberg changed the title fix(eslint-plugin) [member-ordering] account for repeated names fix(eslint-plugin): [member-ordering] account for repeated names Apr 8, 2023
@nx-cloud
Copy link
nx-cloud bot commented Apr 8, 2023 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 83c62c2. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 34 targets

Sent with 💌 from NxCloud.

@codecov
Copy link
codecov bot commented Apr 8, 2023 •
edited
Loading

Codecov Report

Merging #6864 (b783b1e) into main (e5d668c) will decrease coverage by 0.11%.
The diff coverage is 100.00%.

❗ Current head b783b1e differs from pull request most recent head 83c62c2. Consider uploading reports for the commit 83c62c2 to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #6864      +/-   ##
==========================================
- Coverage   87.47%   87.37%   -0.11%     
==========================================
  Files         379      386       +7     
  Lines       13234    13192      -42     
  Branches     3907     3868      -39     
==========================================
- Hits        11577    11526      -51     
- Misses       1279     1300      +21     
+ Partials      378      366      -12
Flag Coverage Δ
unittest 87.37% <100.00%> (-0.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ackages/eslint-plugin/src/rules/member-ordering.ts 96.46% <100.00%> (+0.03%) ⬆️

... and 180 files with indirect coverage changes

@bradzacher bradzacher added the bug Something isn't working label Apr 10, 2023
Josh-Cena
Josh-Cena approved these changes Jul 18, 2023
View reviewed changes
Copy link
Member
@Josh-Cena Josh-Cena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great :)

@bradzacher bradzacher added the 1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge label Jul 18, 2023
@bradzacher bradzacher merged commit d207b59 into typescript-eslint:main Jul 18, 2023
@JoshuaKGoldberg JoshuaKGoldberg deleted the member-ordering-equal-names branch July 18, 2023 11:28
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bradzacher bradzacher bradzacher approved these changes

@Josh-Cena Josh-Cena Josh-Cena approved these changes

Assignees
No one assigned
Labels
1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: [member-ordering] false-positive error when order is set to natural or natural-case-insensitive
3 participants
@JoshuaKGoldberg @bradzacher @Josh-Cena
0