feat(eslint-plugin): add config that disables type-aware linting #6470
Conversation
|
Thanks for the PR, @bradzacher! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. |
| program?: Program; | ||
| project?: string | string[] | true; | ||
| program?: Program | null; | ||
| project?: string | string[] | true | null; |
There was a problem hiding this comment.
Is this needed for this PR?
It's also weird to me IMO to have null be an option only for some of these.
There was a problem hiding this comment.
I added null because it's an explicit value to set these to off that won't get weirdly merged by ESLint's cascading config. It also means the configs can be json-serialized without losing any data (undefined tells a json stringifier to omit the property).
It just means we can be sure these configs are robust.
I also considered using [], but IIRC ESLint's cascading config logic will merge arrays together. Which means that [] is the same as not specifying a value at all.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## v6 #6470 +/- ##
==========================================
+ Coverage 87.10% 87.12% +0.01%
==========================================
Files 362 362
Lines 12471 12473 +2
Branches 3688 3688
==========================================
+ Hits 10863 10867 +4
+ Misses 1261 1260 -1
+ Partials 347 346 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
PR Checklist
Overview
Builds on top of the new config tooling to generate a config that disables type-aware linting.